[WIP] Allow module to document environment variable fallbacks for options #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2022
felixfontein
changed the title
felixfontein
force-pushed
the
env-vars-modules
branch
from
3e7a822 to
6a7b0d4
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
3 times, most recently
from
ac79561 to
f91f1bb
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
from
f91f1bb to
22203fd
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
from
22203fd to
f64a4c1
Compare
Collaborator
Author
|
|
felixfontein
force-pushed
the
env-vars-modules
branch
2 times, most recently
from
76fcb86 to
c98e15b
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
from
c98e15b to
e581253
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
from
e581253 to
173cb98
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
2 times, most recently
from
66ef0d7 to
65ef588
Compare
Merged
felixfontein
force-pushed
the
env-vars-modules
branch
from
65ef588 to
bb30017
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
from
bb30017 to
2e9bf10
Compare
felixfontein
force-pushed
the
env-vars-modules
branch
from
2e9bf10 to
883482c
Compare
Contributor
|
The code so far looks good to me. I'm really looking forward to this! |
Collaborator
Author
|
Core seems to really be opposed to this, so I'm not sure if this will ever be possible this way... |
Contributor
I don't see any real discussion in the core ticket :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #73.This is the controversal part of #73, which allows modules to declare environment variable fallbacks for options.
Related to ansible/ansible#79471.